Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/devsu 2492 add frontend support for kbmatches search #579

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Feat/devsu 2492 add frontend support for kbmatches search #579

merged 5 commits into from
Jan 2, 2025

Conversation

sshugsc
Copy link
Contributor

@sshugsc sshugsc commented Dec 16, 2024

DEVSU-2492

  • add frontend support for kbmatches search

@sshugsc sshugsc self-assigned this Dec 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2024 •
edited
Loading

Test Results

    1 files  ±0    28 suites  ±0   4m 59s ⏱️ +9s
145 tests ±0  145 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
142 runs  ±0  142 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a045c36. ± Comparison against base commit cbf10e4.

♻️ This comment has been updated with latest results.

@kttkjl
chore: move scss of searchView and searchByKbMatches to common
fe6c9bb 
DEVSU-2492
@kttkjl
chore: move onKeyUp listener to TextField inputProps for proper attri…
a045c36 
…butes

  - update references to css classes in searchView and searchByKbMatchesView
DEVSU-2492
kttkjl
kttkjl reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@kttkjl kttkjl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some fixes to styling

  • Threshold now of type number
  • EventListener for KeyDown now on input instead of a div
  • Moved shared CSS for both SearchViews outside into App-level

On commits fe6c9bb and a045c36

@kttkjl kttkjl self-requested a review December 31, 2024 02:12
kttkjl
kttkjl approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@kttkjl kttkjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't just approve my own commits, pinging @elewis2

@sshugsc sshugsc merged commit 7884233 into develop Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnguyen-bcgsc bnguyen-bcgsc bnguyen-bcgsc approved these changes

@kttkjl kttkjl kttkjl approved these changes

@elewis2 elewis2 elewis2 approved these changes

Assignees

@sshugsc sshugsc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sshugsc @elewis2 @kttkjl @bnguyen-bcgsc