Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/devsu 2550 update multivariant stmt handling #45

Merged
merged 22 commits into from
Feb 21, 2025

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Feb 4, 2025

No description provided.

@elewis2 elewis2 marked this pull request as ready for review February 5, 2025 18:10
@elewis2 elewis2 closed this Feb 5, 2025
@elewis2 elewis2 reopened this Feb 5, 2025
@elewis2 elewis2 marked this pull request as draft February 5, 2025 18:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 91.57895% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.34%. Comparing base (6dfd34b) to head (33c73fc).

Files with missing lines Patch % Lines
pori_python/ipr/ipr.py 89.79% 5 Missing ⚠️
pori_python/ipr/main.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
- Coverage    86.50%   86.34%   -0.17%     
===========================================
  Files           18       18              
  Lines         2245     2328      +83     
===========================================
+ Hits          1942     2010      +68     
- Misses         303      318      +15     
Flag Coverage Δ
unittests 86.34% <91.57%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elewis2 elewis2 marked this pull request as ready for review February 13, 2025 17:03
@dustinbleile
Copy link
Contributor

This only works with the devipr. Is that expected?

Otherwise:
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://iprstaging-api.bcgsc.ca/api/reports-async There was an error validating the report content Error: should NOT have additional properties [additionalProperty: kbMatchedStatements]

@elewis2 - is it possible to remove this error or make it an option to check?

@dustinbleile dustinbleile self-requested a review February 14, 2025 17:08
@dustinbleile
Copy link
Contributor

Hi @elewis2 - I would just need to check the ' and False' if statement and verify this only works on the dev ipr

@elewis2
Copy link
Collaborator Author

elewis2 commented Feb 18, 2025

Hi @elewis2 - I would just need to check the ' and False' if statement and verify this only works on the dev ipr

That's correct, it only works on dev ipr.

@elewis2
Copy link
Collaborator Author

elewis2 commented Feb 18, 2025

Right yes re "and False", ty for heads up. Fixing.

@elewis2 elewis2 merged commit 0035155 into develop Feb 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants