Feat(DEVX-410): E2E Tests #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepegler
force-pushed
the
feature/DEVX-410_add-tests
branch
3 times, most recently
from
038f2b4 to
ebd2593
Compare
tidy increase mintNFT timeout Allow sendTransaction to send multiple transactions
joepegler
force-pushed
the
feature/DEVX-410_add-tests
branch
from
ebd2593 to
d6a6242
Compare
Update README.md
AmanRaj1608
reviewed
Jan 5, 2024
AmanRaj1608
reviewed
Jan 5, 2024
AmanRaj1608
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Overall I have these few concerns
- What if there are multiple PR's opening at same time, test might fail if the nonce is incorrect.
- Hard to manage the paymaster with balance.
- For non-gasless tests would need to make sure and have the funds in EOA.
Latency is also one of my concern as build time increases it will cost for on CI/CD infra. In this PR I can see it is 1m. But if we add more tests this can go up really fast.
joepegler
force-pushed
the
feature/DEVX-410_add-tests
branch
from
7f026ce to
ade3271
Compare
|
Even tho I approved this it's still not making the build. Looks like it needs all approvals. |
AmanRaj1608
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notion Doc
Related Issue: #DEVX-410
Change Type
Checklist
Additional Information
I've added some additional aliases for devEx purposes, and then used them in the tests
createSmartWalletAccount -> BiconomySmartAccountV2.create
smartWallet.sendTransaction(s) -> BiconomySmartAccountV2.buildUserOp + BiconomySmartAccountV2.sendUserOp
I've also imported and then re-exported the Bundler and Paymaster packages from the accounts package, so that mostly everything can be important from "@biconomy/account"