feat: added support for PrivateKeyAccount as signer in account config #458
Conversation
| @@ -51,7 +50,17 @@ export const convertSigner = async (signer: SupportedSigner, skipChainIdCalls: b | |||
| } | |||
| // convert viems walletClient to alchemy's SmartAccountSigner under the hood | |||
| resolvedSmartAccountSigner = new WalletClientSigner(walletClient, "viem"); | |||
| rpcUrl = walletClient?.transport?.url ?? null; | |||
| rpcUrl = walletClient?.transport?.url ?? undefined; | |||
| } else if (signer as PrivateKeyAccount) { | |||
There was a problem hiding this comment.
I think this should be instanceof instead of as
There was a problem hiding this comment.
You're casting every other signer to a PrivateKeyAccount here, - not just accounts.
There was a problem hiding this comment.
instanceof works with classes, it does not work with types
There was a problem hiding this comment.
You're casting every other signer to a PrivateKeyAccount here, - not just accounts.
Not sure what do you mean as this is the last "else if", it will cast it only if signer is indeed of PrivateKeyAccount type, otherwise it will break and throw an error.
There was a problem hiding this comment.
This was changed, please review
| @@ -55,7 +55,7 @@ export const compareChainIds = async ( | |||
| biconomySmartAccountConfig: BiconomySmartAccountV2Config, | |||
| skipChainIdCalls: boolean, | |||
| ): Promise<Error | void> => { | |||
| const signerResult = await convertSigner(signer, skipChainIdCalls); | |||
| const signerResult = await convertSigner(signer, skipChainIdCalls, biconomySmartAccountConfig.rpcUrl); | |||
There was a problem hiding this comment.
If a user passes a PrivateKeyAccount there is no info about transport so he needs to at least pass rpcUrl in the config so we can properly construct the walletClient with the correct transport
There was a problem hiding this comment.
This was also changed to a better approach
|
resolve conflicts |
|
LGTM. We can close this as I have added it here: bb9ba8e |
Summary
Added PrivateKeyAccount support as direct signer in account config.
Change Type
Checklist