Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor codebase #574

Merged
merged 31 commits into from
Sep 19, 2024
Merged

chore: refactor codebase #574

merged 31 commits into from
Sep 19, 2024

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Sep 13, 2024

PR-Codex overview

This PR focuses on restructuring the project directory, updating imports, and improving file organization for better readability and maintainability.

Detailed summary

  • Restructured project directory, updated imports, and improved file organization
  • Renamed and moved files for better readability and maintainability
  • Updated import paths and references to reflect the new project structure

The following files were skipped due to too many changes: src/bundler/utils/getAAError.ts, src/account/utils/getChain.ts, src/sdk/modules/validators/ValidationModule.ts, src/sdk/modules/validators/K1ValidatorModule.ts, package.json, tests/src/testSetup.ts, CHANGELOG.md, src/sdk/clients/createBicoBundlerClient.ts, src/sdk/clients/decorators/smartAccount/signMessage.ts, src/sdk/account/utils/toHolder.ts, src/sdk/clients/decorators/erc7579/getActiveHook.ts, src/modules/base/BaseModule.ts, scripts/send:userOp.ts, src/sdk/clients/createBicoPaymasterClient.ts, src/sdk/account/utils/utils.test.ts, scripts/fetch:deployment.ts, src/sdk/clients/decorators/erc7579/accountId.ts, src/sdk/account/utils/Types.ts, src/sdk/clients/decorators/erc7579/getFallbackBySelector.ts, src/modules/base/BaseValidationModule.ts, src/sdk/clients/decorators/erc7579/installModule.ts, src/sdk/clients/decorators/smartAccount/writeContract.ts, src/sdk/clients/decorators/erc7579/getInstalledExecutors.ts, src/sdk/clients/decorators/erc7579/getInstalledValidators.ts, src/sdk/clients/decorators/erc7579/uninstallModule.ts, src/sdk/clients/decorators/erc7579/uninstallFallback.ts, src/sdk/clients/decorators/erc7579/uninstallModules.ts, src/sdk/clients/decorators/smartAccount/sendTransaction.ts, src/sdk/clients/createBicoBundlerClient.test.ts, src/sdk/clients/decorators/erc7579/installModules.ts, src/sdk/clients/decorators/smartAccount/signTypedData.ts, src/account/utils/Constants.ts, src/sdk/clients/decorators/erc7579/isModuleInstalled.ts, src/sdk/modules/validators/k1Validator.test.ts, src/sdk/clients/decorators/erc7579/erc7579.decorators.test.ts, src/sdk/clients/decorators/erc7579/supportsModule.ts, src/account/utils/Utils.ts, scripts/viem:bundler.ts, tests/smart.sessions.test.ts, src/sdk/clients/decorators/smartAccount/account.decorators.test.ts, src/sdk/clients/decorators/erc7579/supportsExecutionMode.ts, src/sdk/clients/decorators/erc7579/index.ts, src/modules/executors/OwnableExecutor.ts, src/modules/utils/Types.ts, tests/playground.test.ts, src/sdk/clients/createNexusClient.ts, src/sdk/clients/createNexusClient.test.ts, src/sdk/account/toNexusAccount.test.ts, tests/src/testUtils.ts, src/sdk/clients/decorators/smartAccount/index.ts, src/sdk/account/toNexusAccount.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joepegler joepegler force-pushed the refactor/codebase branch 3 times, most recently from e111dfc to 381fb9d Compare September 13, 2024 20:34
@joepegler joepegler force-pushed the refactor/codebase branch 3 times, most recently from 3402652 to cf1ddce Compare September 16, 2024 16:27
@joepegler joepegler force-pushed the refactor/codebase branch 3 times, most recently from a96a5f3 to 61ed763 Compare September 17, 2024 12:16
@joepegler joepegler marked this pull request as ready for review September 17, 2024 12:16
@joepegler joepegler force-pushed the refactor/codebase branch 3 times, most recently from 8ce67b1 to e749894 Compare September 17, 2024 14:07
package.json Outdated Show resolved Hide resolved
@@ -162,15 +163,11 @@ export function convertToFactor(percentage: number | undefined): number {

export function makeInstallDataAndHash(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this method do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VGabriel45 this was your addition I believe

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for enableMode, will be helpful when we'll integrate it.

@joepegler
Copy link
Collaborator Author

joepegler commented Sep 18, 2024

Size limit is failing just because of the base branch. This PR is ready to be merged despite that failing test

@joepegler joepegler force-pushed the refactor/codebase branch 2 times, most recently from 5db0bfc to 693970c Compare September 18, 2024 15:11
@joepegler joepegler force-pushed the refactor/codebase branch 2 times, most recently from 9d8ec81 to 9300d5c Compare September 19, 2024 11:59
@joepegler joepegler force-pushed the refactor/codebase branch 4 times, most recently from 8e58906 to 1edbe9f Compare September 19, 2024 12:21
Copy link

size-limit report 📦

Path Size
core (esm) 11.11 KB (-33.82% 🔽)
core (cjs) 17.14 KB (-22.07% 🔽)
bundler (tree-shaking) 197 B (-95.93% 🔽)
paymaster (tree-shaking) 108 B (-95.64% 🔽)

@joepegler joepegler merged commit f548ab4 into feat/nexus Sep 19, 2024
3 checks passed
@joepegler joepegler deleted the refactor/codebase branch September 19, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants