Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better homing for the midTbot #914

Open
wants to merge 7 commits into
base: Devt
Choose a base branch
from

Conversation

odaki
Copy link
Contributor

@odaki odaki commented Jun 6, 2021

Hi Bart.

It's been a while since I've updated the firmware on my lovely midTbot.
I feel that the homing behavior of the current midTbot is a little different from what you intended, so I suggest some changes.

(1) Mpos of X seems to be shifted from its original value when homing.
It seems to be caused by a typo in midtbot.h.
It reads as if it was originally intended to PenUp after homing, but that doesn't seem to work in the current implementation.

(2) PenDown occurs when homing.
In the current implementation, the Z axis is homed first, so it is PenDown (Z is set to 0) first.
Then, since it is PenDown, it will homing the Y and X axis while drawing with the pen.
So in the current implementation, I would suggest not homing the Z axis with $H.
If you must, you can handle it separately with $HZ.

The cause of the PenDown when homing was that the Z axis was not specified in DEFAULT_DIRECTION_INVERT_MASK.

Thank you for your consideration.

odaki added 2 commits June 6, 2021 18:43
I suspect that DEFAULT_X_HOMING_MPOS is a typo for DEFAULT_Z_HOMING_MPOS.
However, even if this is fixed, the current implementation does not seem to be able to achieve PenUp after Homing simply by changing the HOMING_MPOS setting.
Therefore, I decided to remove this setting.
Since midTbot's Z axis is servo, I consider Z axis homing unnecessary.
@bdring
Copy link
Owner

bdring commented Jun 7, 2021

It is good to hear from you again.

I will look at this when I get a chance.

The last time I checked, I think it was working OK. You should be able to change the homing direction based on the $Homing/DirInvert and $Home/Mpos settings.

@odaki
Copy link
Contributor Author

odaki commented Apr 23, 2022

The cause of the PenDown when homing was that the Z axis was not specified in DEFAULT_DIRECTION_INVERT_MASK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants