Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AbstractString in empairs crossing #65

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

palday
Copy link
Member

@palday palday commented Mar 13, 2024

closes #63

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (a8aeed4) to head (29e1b9b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           6        6           
  Lines         174      174           
=======================================
  Hits          173      173           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday palday requested a review from jmmanley March 13, 2024 17:54
Copy link

@jmmanley jmmanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL InlineStrings! I didn't notice any other strict string type restrictions.

Failing tests are due to MixedModels.jl erroring on julia nightly.

@palday palday merged commit f5e13ad into main Mar 13, 2024
8 of 10 checks passed
@palday palday deleted the pa/loosen_string_restriction branch March 13, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error from empairs
3 participants