Make atoms and string keys the same in aggregator #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason i think this is important is because they show up the same in the exporter since atoms and string serialize the same. The end result is you get two metrics with the same labels in your prometheus output which causes prometheus to fail to be able to scrape the endpoint due to bad data (duplicated entries) To resolve this I suggest this PR which makes atoms and strings fundamentally the same in the aggregator to it's internal ETS table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason i think this is important is because they show up the same in the exporter since atoms and string serialize the same.
The end result is you get two metrics with the same labels in your prometheus output which causes prometheus to fail to be able to scrape the endpoint due to bad data (duplicated entries)
It was pretty hard to track down but eventually I noticed the difference by checking the internal aggregation tables with
TelemetryMetricsPrometheus.Core.Aggregator.get_time_seriesand filtering for the metric i was looking for and seeing what it was being stored asTo resolve this I suggest this PR which makes atoms and strings fundamentally the same in the aggregator to it's internal ETS table