Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for extra event functions #35

Merged
merged 27 commits into from
Nov 15, 2023
Merged

Conversation

MICHAELMUNAVU83
Copy link
Collaborator

In this PR , I added tests for the following functions get_all_available_tickets , get_elixir_conf_event , get_elixir_conf_event_and_ticket_types

lib/elixir_conf_africa/events.ex Outdated Show resolved Hide resolved
Copy link
Collaborator

@okothkongo okothkongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes us sure that the inserted event is of the same name as the one we get with get_elixir_conf_event /0?

What if we insert two events with the same name 🤔

test/support/factory.ex Outdated Show resolved Hide resolved
test/elixir_conf_africa/events_test.exs Outdated Show resolved Hide resolved
@MICHAELMUNAVU83
Copy link
Collaborator Author

What makes us sure that the inserted event is of the same name as the one we get with get_elixir_conf_event /0?

What if we insert two events with the same name 🤔

@okothkongo , we can add a unique constraint to the name , would this suffice?

@okothkongo okothkongo force-pushed the testing-event-functions branch from be1313c to be7f141 Compare November 14, 2023 12:45
remove unnecessary funcs
refacor other code
@okothkongo okothkongo force-pushed the testing-event-functions branch 2 times, most recently from f864473 to 346c580 Compare November 15, 2023 07:21
@okothkongo okothkongo force-pushed the testing-event-functions branch from 346c580 to be0b057 Compare November 15, 2023 07:30
@okothkongo okothkongo merged commit 976c545 into main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants