Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case from #117 checking for varargs ambiguity #150

Merged
merged 1 commit into from
May 18, 2024

Conversation

PhilipVinc
Copy link
Collaborator

I recently noticed that for some reason a test case I had added in #119 that previously did not pass test, now pass.

The test is that the following raises an AmbiguousLookupError

def f(x : int, *y: A):
 pass
def f(x: int, *y : B):
 pass

f(1)

I would like to add this to the test set of plum just so that it's included.

Note that #117 is still not solved as we still do not pass this other test

assert Sig(int, varargs=int) < Sig(int, Num)

but that's a step in the right direction...

@PhilipVinc PhilipVinc requested a review from wesselb May 14, 2024 10:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9077591603

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.919%

Totals Coverage Status
Change from base Build 9075861722: 0.0%
Covered Lines: 1226
Relevant Lines: 1227

💛 - Coveralls

@wesselb
Copy link
Member

wesselb commented May 18, 2024

Thanks, this looks great! :) Merging right away.

@wesselb wesselb merged commit 488131d into beartype:master May 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants