Use Dependency Injection Everywhere #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theospears
force-pushed
the
dependency-injection-everywhere
branch
from
03a27bd to
777eeda
Compare
theospears
force-pushed
the
dependency-injection-everywhere
branch
from
87f62d7 to
91266ed
Compare
krugerk
reviewed
Jan 17, 2025
| @@ -3,14 +3,16 @@ | |||
| // BeeSwift | |||
| // | |||
| // Created by Andy Brett on 3/14/17. | |||
| // Copyright 2017 APB. All rights reserved. | |||
| // Copyright © 2017 APB. All rights reserved. | |||
There was a problem hiding this comment.
👀
Some MRs ago these were all removed
There was a problem hiding this comment.
Doh. I wonder how this merge conflict snuck in
There was a problem hiding this comment.
swiftformat can be configured to adjust file headers and it could be run as part of a general format-code or ci-check/build step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove almost all references to ServiceLocator. Instead use a dependency injection pattern to pass required objects in via constructor parameters.
Validation
Launch the app in simulator. Verify I can navigate to the impacted views: