meta datapoints being deleted or overwritten

[krugerk]

Summary

Meta datapoints refer to those beeminder itself creates to indicate things like goal has been restarted, when a goal has been created, when a derailment has occurred and so on. The app differentiates these so as to not delete them when syncing data to goals from HealthKit. Currently the app does not consider origin.

Validation

Had a goal with a manually created datapoint with one of the known strings.
Same goal also had a similar datapoint generated from beeminder.
Goal was integrated with HealthKit.

Would fix #598

[theospears]

@dreeves how would you feel about making a small server side tweak to add dummy (boolean) and possibly initial (boolean) to the datapoint resource in the API, rather than the iOS app reproducing this logic?

[bsoule]

@dreeves how would you feel about making a small server side tweak to add dummy (boolean) and possibly initial (boolean) to the datapoint resource in the API, rather than the iOS app reproducing this logic?

adding fields to the resource is cheap and not harmful to any of the code we're maintaining, i don't think. i guess initial is just origin == nihilo? what do you mean by/about dummy however?

[theospears]

I hear the datapoint now has is_dummy and is_initial, so let's use those and get rid of the isMeta helper entirely.
Probably the behavior should be slightly different in different places, e.g. apple health sync should ignore both, and the default input value should ignore is_dummy but include is_initial (e.g. for lose weight goals)