notificationsVC could crash when group membership changed #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
commented
Jan 22, 2025
switch to a diffable datasource for the tableview listing the entry points for the default notifications and for the notification settings of each goal also used the hud activity indicator throughout fixes beeminder#397
krugerk
force-pushed
the
bugfix/397-crash-when-changing-notification-settings
branch
from
8c7f2b9 to
83fc587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NotificationsVC could crash when the underlying list of goals changed. The MR makes the code more robust by using a diffable datasource for the NotificationVC's TableView.
Also took the opportunity to add the HUD activity indicator when notification settings are being saved.
fixes #397
For UI changes including screenshots of before and after is great.
Validation
Ran app in simulator.
Changed settings in goals. Returned from notification/goal screen back to notification goal list. Noticed goals were in their proper sections.