Disable animation for goal thumbnails #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theospears
changed the title
krugerk
reviewed
Jan 26, 2025
| @@ -77,8 +77,13 @@ class GoalImageView : UIView { | |||
|
|
|||
| @MainActor | |||
| private func showGraphImage(image: UIImage) { | |||
| // Animating the thumbnail view interacts badly with cell re-use in the gallery | |||
There was a problem hiding this comment.
I would guess there is something wrong with the cell or the GoalImageView itself.
GoalCollectionViewCell has its prepareForReuse method which is called when the system is about to reuse a cell. The method should finish with the cell being in the state that it can be reused again. As is, it sets the thumbnailImageView's goal to nil.
The expectation is probably that doing so would set the thumbnailImageView to set the graph placeholder as the image or at the very least remove the previously associated graph-thumbnail.
So what is going on in the lifecycle of GoalImageView? When is clearGoalGraph being called?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Animation of goal thumbnails in the gallery often had some unfortunate affects:
It may be possible to more carefully choose when to animate to address these, but for now avoid the issue by not animating thumbnails.
Validation
Loaded the app and navigated to a goal and back. Observed the gallery immediately showed the correct graphs.