A coordinator handles the app's navigation #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
commented
Jan 26, 2025
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { | ||
| var section = indexPath.section | ||
| guard let cell = tableView.dequeueReusableCell(withIdentifier: self.cellReuseIdentifier) as? SettingsTableViewCell else { return UITableViewCell() } | ||
| if HKHealthStore.isHealthDataAvailable() { |
There was a problem hiding this comment.
admittedly, these are not directly related to the introduction of the coordinator
krugerk
force-pushed
the
feature/coordinator-for-navigation
branch
from
b0f4fd8 to
2408680
Compare
krugerk
force-pushed
the
feature/coordinator-for-navigation
branch
from
2408680 to
dc06f35
Compare
probably broke with the transition from appDelegate to sceneDelegate whereas tapping the result would merely open the app; now it also opens the goal
krugerk
commented
Jan 26, 2025
| coordinator?.start() | ||
| } | ||
|
|
||
| func scene(_ scene: UIScene, continue userActivity: NSUserActivity) { |
There was a problem hiding this comment.
proposed #628 for just the fix
|
Ah, it looks like this was closed because the wrong number was mentioned in a merged commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Navigation was somewhat scattered throughout the app and the gallery had a central role. This merge request introduces a class for handling the app's navigation. Eventually it could also help with scenarios like starting the app from cold start with the running timer for a particular goal shown.
For UI changes including screenshots of before and after is great.
Validation
Running the app in the simulator.
Navigating around:
Fixes #622
Other Locations: