Search goals also in title #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
commented
Feb 23, 2025
| @@ -98,7 +98,7 @@ class GalleryViewController: UIViewController { | |||
| let searchBar = UISearchBar() | |||
| searchBar.accessibilityIdentifier = "searchBar" | |||
| searchBar.delegate = self | |||
| searchBar.placeholder = "Filter goals by slug" | |||
| searchBar.placeholder = "Search goals" | |||
There was a problem hiding this comment.
Nit: on the Goals page, search is nice and snappy but the “Filter goals by slug” copy is really a back-of-house term, would recommend just “Search goals” instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #631 it was requested that the search works should be extended to search also in goals' descriptions (here
titles).For UI changes including screenshots of before and after is great.
https://forum.beeminder.com/t/ios-ux-comments/12243
Validation
Ran app in simulator. Searched goals for things appearing in titles and not in goal names. Searched goals for things appearing in names and not titles. Noticed (expected) results both times.
Fixes #631