Remove duplicate BeeSwiftUITests section #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about removing the "empty" test files and tests as well? |
krugerk
reviewed
Feb 23, 2025
There was a problem hiding this comment.
This MR is missing a change to the BeeSwift.xcodeproj/project.pbxproj file, such as
--- a/BeeSwift.xcodeproj/project.pbxproj
+++ b/BeeSwift.xcodeproj/project.pbxproj
@@ -447,7 +447,6 @@
children = (
A196CB161AE4142E00B90A3E /* BeeSwift */,
A196CB2F1AE4142F00B90A3E /* BeeSwiftTests */,
- E5FEFB3F24E6FAD900A076BB /* BeeSwiftUITests */,
E5FEFB3624E6FAC800A076BB /* BeeSwiftUITests */,
E5F7C493260FC5300095684F /* BeeSwiftIntents */,
E57BE6E12655EBDA00BA540B /* BeeKit */,
@@ -681,17 +680,9 @@
children = (
E5FEFB3724E6FAC800A076BB /* BeeSwiftUITests.swift */,
E5FEFB3924E6FAC800A076BB /* Info.plist */,
- );
- path = BeeSwiftUITests;
- sourceTree = "<group>";
- };
- E5FEFB3F24E6FAD900A076BB /* BeeSwiftUITests */ = {
- isa = PBXGroup;
- children = (
E5FEFB4024E6FAFC00A076BB /* LaunchScreenTests.swift */,
);
- name = BeeSwiftUITests;
- path = BeeSwift/BeeSwiftUITests;
+ path = BeeSwiftUITests;
sourceTree = "<group>";
};
/* End PBXGroup section */
theospears
force-pushed
the
dupe-ui-tests
branch
from
9e762b9 to
bc228fc
Compare
Seems reasonable, although making them real tests would be better of course :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were two sections for UI test for some reason. Combine them.
Validation
None