Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace probot-config with context.config #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GeorgianaElena
Copy link

@GeorgianaElena GeorgianaElena commented May 1, 2020

The probot-config repository has been archived and implemented in probot itself (ref: probot/probot#975).

This PR:

  • removes probot-config and replaces it with context.config
  • bumps the probot version to a version that includes probot-config
    • replace deprecated getContent with getContents
    • replace deprecated .event prop with .name
      (ref: v9.0.0 breaking changes)

I think this will also solve #48.

cc @hiimbex

@welcome
Copy link

welcome bot commented May 1, 2020

Thanks so much for opening your first PR here!

@update-docs
Copy link

update-docs bot commented May 1, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

@GeorgianaElena GeorgianaElena force-pushed the useContextConfig branch 2 times, most recently from a460f57 to 9e7c931 Compare May 1, 2020 13:18
@GeorgianaElena
Copy link
Author

The tests are passing 🎉, so this should be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants