Add CONFIG_NO_WORKER Makefile option #300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a bit of a background, I was inspecting one of my executables which embeds QuickJS and noticed in the symbols listing with My code is not using any workers and was hoping with link-time optimization it wouldn't need to bring in pthreads at all. Looking at QuickJS I noticed I wasn't sure about the name, and since we have |
TooTallNate
pushed a commit
to TooTallNate/quickjs
that referenced
this pull request
Jul 3, 2024
- fix incorrect argument in s = `JSON.stringify(s);` - add closures for `RegExp` and `JSON`
This option eliminates the dependency on the pthread library. This mode is already toggled on _WIN32 and/or EMSCRIPTEN is detected, here we just allow the user to toggle it at will at the top level. This slightly reduce the code size as well, and may allow compiling this library in some embedded contexts where pthread is not available or is broken.
nickva
force-pushed
the
no-worker-config-option
branch
from
79ba139
to
fdc6ba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option eliminates the dependency on the pthread library. This mode is already toggled on _WIN32 and/or when EMSCRIPTEN is detected, here we just allow the user to toggle it at will at the top level.
This slightly reduces the code size as well, and may allow compiling this library in some embedded contexts where pthread is not available or is broken.