tried to reduce the uses of sender_decompose #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
reviewed
Jan 20, 2025
| if(NOT PROJECT_IS_TOP_LEVEL) | ||
| if(ROJECT_IS_TOP_LEVEL) |
There was a problem hiding this comment.
Why do you change the logic?
There was a problem hiding this comment.
This change I committed by accident: during development this one check take by far most time for me:
- buildung and testing everything else takes < 2s
- this test alone takes > 10s
That interferes with my development which compiles/tests often. Sadly, I haven't found a way to disable this test without modifying the CMakeLists.txt. I guess, I should set up a pre-commit check making sure I undo the change. Being able to disable this test without modifying the CMakeLists.txt would be better, though.
dietmarkuehl
added a commit
that referenced
this pull request
Jan 21, 2025
* tried to reduce the uses of sender_decompose * clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.