avoid debug flags spilling into dependent projects

[dietmarkuehl]

No description provided.

[ClausKlein]

That isn't a good idea 👎

[neatudarius]

That isn't a good idea 👎

Can you explain?

[ClausKlein]

This disables the project_options completely -> cache, warnings, sanitizer, ...!

  project_options(
    PREFIX
    ${TARGET_NAME}
    ENABLE_CACHE
    # NO! # ENABLE_CLANG_TIDY
    # NO! ENABLE_VS_ANALYSIS
    # ENABLE_INTERPROCEDURAL_OPTIMIZATION
    # ENABLE_NATIVE_OPTIMIZATION
    # ENABLE_DOXYGEN
    # ENABLE_COVERAGE
    ENABLE_SANITIZER_ADDRESS
    ENABLE_SANITIZER_UNDEFINED
    # TODO: ENABLE_SANITIZER_THREAD
    # FIXME: on Linux only with clang++? ENABLE_SANITIZER_MEMORY
    ENABLE_SANITIZER_POINTER_COMPARE
    ENABLE_SANITIZER_POINTER_SUBTRACT
    ENABLE_CONTROL_FLOW_PROTECTION
    ENABLE_STACK_PROTECTION
    ENABLE_OVERFLOW_PROTECTION
    # ENABLE_ELF_PROTECTION
    # ENABLE_RUNTIME_SYMBOLS_RESOLUTION
    # ENABLE_COMPILE_COMMANDS_SYMLINK
    # ENABLE_PCH
    # PCH_HEADERS
    # WARNINGS_AS_ERRORS
    # ENABLE_INCLUDE_WHAT_YOU_USE
    # ENABLE_GCC_ANALYZER
    # ENABLE_BUILD_WITH_TIME_TRACE
    # TODO: buggy! ENABLE_UNITY
    # LINKER "lld"
  )

[dietmarkuehl]

I agree that this isn't the correct approach. I had tried quite a while to find a way to build a dependent project (https://github.com/bemanproject/lazy ) with TSAN but I didn't manage to not have other sanitizers desabled. Disabling this block did it. It should be restored but in a way which is compatible with dependent projects. I'm not a cmake expert and don't know how to make that happen properly.

[neatudarius]

I propose to move the discussion into a new issue, which can be a follow-up task.