-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve README file #111
base: main
Are you sure you want to change the base?
Improve README file #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few suggestions. I like the notes you left to yourself.
I am definitely looking forward to the docs on pre-commit and how to run GitHub Actions locally. If our Spaces environment comes already prepared for those workflows, even better.
One suggestion: it's probably true that more users will just want to consume and build Beman libraries than make changes to them. Let's consider creating a CONTRIBUTING.md
file and putting instructions in there that you wouldn't need if you were happy just building a release of this repo.
README.md
Outdated
This project pulls [Google Test](https://github.com/google/googletest) | ||
from GitHub as a development dependency, | ||
you can disable this behavior by setting `BEMAN_EXEMPLAR_BUILD_TESTS` to `OFF`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remind me to update this section of the README whenever we decide on an approach to make the http-based dependency resolution optional.
Yeah one of the main goal is to minimize the amount of replacement we need for the initial setup. We don't have to be exhaustive with those. |
Fix #97 .
Major painpoints in current README:
pre-commit
, CMake preset,codespace
)This PR aim to fix these issues.
Major TODOs
pre-commit