Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README file #111

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

wusatosi
Copy link
Member

@wusatosi wusatosi commented Feb 2, 2025

Fix #97 .

Major painpoints in current README:

  • Current README is full of TODOs
  • Not all of our developer tools have been documented (pre-commit, CMake preset, codespace)
  • A lot of replacement needed to bootstrap a new project

This PR aim to fix these issues.

Major TODOs

  • Address all current TODOs, mostly left out explicitly to @neatudarius
  • Define minimal C++ version
  • Define minimal CMake version
  • Define tested range of compiler support
  • Document that cmake config requires internet access due to testing
  • Document CMake config flags: Disable Tests
  • Document CMake config flags: Disable examples
  • Document codespace support as rapid development
  • Document CMake preset as one-line configuration
  • Document developer facing tool: pre-commit
  • Document developer facing tool: Current GitHub Action workflow and how to update them.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bretbrownjr bretbrownjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions. I like the notes you left to yourself.

I am definitely looking forward to the docs on pre-commit and how to run GitHub Actions locally. If our Spaces environment comes already prepared for those workflows, even better.

One suggestion: it's probably true that more users will just want to consume and build Beman libraries than make changes to them. Let's consider creating a CONTRIBUTING.md file and putting instructions in there that you wouldn't need if you were happy just building a release of this repo.

README.md Outdated
Comment on lines 94 to 96
This project pulls [Google Test](https://github.com/google/googletest)
from GitHub as a development dependency,
you can disable this behavior by setting `BEMAN_EXEMPLAR_BUILD_TESTS` to `OFF`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remind me to update this section of the README whenever we decide on an approach to make the http-based dependency resolution optional.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@wusatosi
Copy link
Member Author

wusatosi commented Feb 3, 2025

One suggestion: it's probably true that more users will just want to consume and build Beman libraries than make changes to them. Let's consider creating a CONTRIBUTING.md file and putting instructions in there that you wouldn't need if you were happy just building a release of this repo.

Yeah one of the main goal is to minimize the amount of replacement we need for the initial setup. We don't have to be exhaustive with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better README
2 participants