Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install debug build binaries to a separate folder #39

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

ComicSansMS
Copy link
Contributor

This will mirror the directory structure used by vcpkg:

  • Debug binaries will get installed to a subdirectory debug/lib for ARCHIVE and LIBRARY artifacts and debug/bin for RUNTIME artifacts
  • All other configurations install binaries directly to lib and bin respectively
  • Other artifacts go to the same include/share/... directories for all configurations, including Debug

This will mirror the directory structure used by vcpkg:
* Debug binaries will get installed to a subdirectory debug/lib for
  ARCHIVE and LIBRARY artifacts and debug/bin for RUNTIME artifacts
* All other configurations install binaries directly to lib and bin
  respectively
* Other artifacts go to the same include/share/... directories for all
  configurations, including Debug
@camio
Copy link
Member

camio commented Oct 1, 2024

Thanks for the contribution @ComicSansMS! Could you add to the .github/workflows/ci_tests.yml a check so we can verify this works properly (at least by eye)? I'm thinking a Ninja MultiConfig including both debug and release builds.

@ComicSansMS
Copy link
Contributor Author

Thanks for the contribution @ComicSansMS! Could you add to the .github/workflows/ci_tests.yml a check so we can verify this works properly (at least by eye)? I'm thinking a Ninja MultiConfig including both debug and release builds.

So, the easiest way to do this is to just have all builds always build both Debug and Release configurations. I added that change to the PR.

To properly ensure that this works, we will eventually need a CI job that mimics a client application consuming the exemplar library in different configurations. I will leave that for another PR though, as it requires a completely new CI job that will be quite a bit more complex than what we have now.

Copy link
Member

@camio camio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again for the contribution.

@camio camio merged commit 0ac15db into bemanproject:main Oct 2, 2024
13 checks passed
@wusatosi wusatosi mentioned this pull request Oct 15, 2024
@camio camio mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants