Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some modifications for Beman standard conformance #8

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

camio
Copy link
Member

@camio camio commented Oct 17, 2024

  • Use FetchContent to pull in GoogleTest instead of a submodule.
  • Change external interface to match library name.
  • Rename directories.

These changes were needed to incorporate this into another project that
uses both GoogleTest and beman.iterator_interface26.

- Use FetchContent to pull in GoogleTest instead of a submodule.
- Change external interface to match library name.
- Rename directories.

These changes were needed to incorporate this into another project that
uses both GoogleTest and beman.iterator_interface26.
@camio camio requested a review from steve-downey as a code owner October 17, 2024 23:14
@camio camio mentioned this pull request Oct 18, 2024
Copy link
Member

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for taking the time to clean this up!

@steve-downey steve-downey merged commit 73c351c into bemanproject:main Oct 18, 2024
2 of 4 checks passed
Copy link
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants