rename net29 -> net

[dietmarkuehl]

No description provided.

[neatudarius]

Link to bemanproject/beman#85

[neatudarius]

LGTM 👍

Btw, I noticed net & execution repos do not have review rules enforced. I change the repo settings.

[dietmarkuehl]

So you are saying I'll need to get my changes reviewed? I'm certainly not against reviews. Probably means I'll need to adjust my workflow.

[neatudarius]

So you are saying I'll need to get my changes reviewed? I'm certainly not against reviews. Probably means I'll need to adjust my workflow.

Short answer yes, but I don't want to cause trouble if you have something urgent.

When I closed bemanproject/beman#67, I was pretty sure that all repos had these rules enforced. Yesterday I noticed they were missing from net / execution, I my intuition was to re-apply the settings.

Currently, these repos have CODEOWNERS == "Dietmar + David + Darius". Feel free to extend the list. I am happy to help with review from time to time. I think you said at some point about onboarding more people into this code. CODEOWNERS files is one way to do it :D (but ofc, it will raise opinions and may sometimes slow down the process).

Let me know if you want to have an exception for your repos.

[dietmarkuehl]

I don't think there are currently any active collaborators. Thus, getting code reviews may be tricky. I wouldn't be surprised if that is a common pattern, at least for projects under development. Of course, we'd like to get all code reviewed.

Currently, at least net lets me override the restriction (I'm not sure what the state of execution is). It is probably worth discussing how we want to handle that. I'll add an item to the agenda. ...or should it be a Discourse?

[neatudarius]

I don't think there are currently any active collaborators. Thus, getting code reviews may be tricky. I wouldn't be surprised if that is a common pattern, at least for projects under development. Of course, we'd like to get all code reviewed.

Currently, at least net lets me override the restriction (I'm not sure what the state of execution is). It is probably worth discussing how we want to handle that. I'll add an item to the agenda. ...or should it be a Discourse?

Please open a thread on discourse - next meeting is reserver for the website discussion. Also link bemanproject/beman#67 on that thread. Meanwhile, you are admin on both repos and you can merge any PR with extra permissions. I would like to keep the rules anyways for other contributors, to be reviewed at least by Dietmar or other codeowners. TLDR: at least now we add more control for outsider contributors, and still letting you to use "fast merge" :D

[dietmarkuehl]

I don't think there are currently any active collaborators. Thus, getting code reviews may be tricky. I wouldn't be surprised if that is a common pattern, at least for projects under development. Of course, we'd like to get all code reviewed.
Currently, at least net lets me override the restriction (I'm not sure what the state of execution is). It is probably worth discussing how we want to handle that. I'll add an item to the agenda. ...or should it be a Discourse?

Please open a thread on discourse - next meeting is reserver for the website discussion. Also link bemanproject/beman#67 on that thread. Meanwhile, you are admin on both repos and you can merge any PR with extra permissions. I would like to keep the rules anyways for other contributors, to be reviewed at least by Dietmar or other codeowners. TLDR: at least now we add more control for outsider contributors, and still letting you to use "fast merge" :D

Well, I can't merge the PR renaming execution26 to execution: I can't get to the extra permission thing on the UI. I'm not sure what is missing.

[neatudarius]

Well, I can't merge the PR renaming execution26 to execution: I can't get to the extra permission thing on the UI. I'm not sure what is missing.

refresh and try again please (I forgot to specify exception for admins :D)

[dietmarkuehl]

Now it worked! Thanks!

I have landed the change and updated the name. There is stil a bit. residual work to update net and lazy (and a few branches). I hope to do that tomorrow.