Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant overloads on is_convertible #100

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Remove redundant overloads on is_convertible #100

merged 1 commit into from
Jan 18, 2025

Conversation

steve-downey
Copy link
Member

The overloads date back to C++ versions that needed them to distinguish if explicit was conditional or not. As explicit now takes an expression, the additional overloads are entirely redundant.

@steve-downey
Remove redundant overloads on is_convertible
cb33563 
The overloads date back to C++ versions that needed them to distinguish if
`explicit` was conditional or not. As `explicit` now takes an expression, the
additional overloads are entirely redundant.
@coveralls
Copy link

Coverage Status

coverage: 93.333% (-0.1%) from 93.443%
when pulling cb33563 on steve-downey:dup-funcs
into 4e8377f on bemanproject:main.

@steve-downey steve-downey merged commit b383b1a into bemanproject:main Jan 18, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neatudarius neatudarius neatudarius approved these changes

@camio camio Awaiting requested review from camio camio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steve-downey @coveralls @neatudarius