Apply the Beman Standard; more tree refactoring #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neatudarius
commented
Jun 12, 2024
| #include <beman/optional/optional.hpp> | ||
|
|
||
| #include <beman/optional/optional.hpp> | ||
| #include <Beman/Optional26/optional.hpp> |
There was a problem hiding this comment.
No need for second include here, we already test this in src/beman/optional/optional.t.cpp.
neatudarius
commented
Jun 12, 2024
| @@ -85,27 +83,26 @@ TEST(OptionalMonadicTest, Transform) { | |||
|
|
|||
| } | |||
|
|
|||
| TEST(OptionalMonadicTest, TransformConstexpr) { | |||
|
|
|||
There was a problem hiding this comment.
Some linting issues were also fixed.
neatudarius
force-pushed
the
neatudarius/code-cleanup
branch
from
588da95 to
9cc9db0
Compare
neatudarius
changed the title
neatudarius
force-pushed
the
neatudarius/code-cleanup
branch
2 times, most recently
from
e85bbec to
1a8b227
Compare
neatudarius
force-pushed
the
neatudarius/code-cleanup
branch
from
1a8b227 to
221f1cf
Compare
neatudarius
changed the title
neatudarius
force-pushed
the
neatudarius/code-cleanup
branch
from
91a0342 to
a88cbbb
Compare
steve-downey
added a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the Beman Standard to C++ code & more tree refactoring:
optional.hpptoinclude/Beman/Optional26/optional.hpp; renamesrc/bemantosrc/Bemanto match theinclude/tree.optional.atobeman_optional26./examples,This should solve remaining parts from #12, after #5.