Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit configs #88

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Update pre-commit configs #88

merged 6 commits into from
Dec 12, 2024

Conversation

wusatosi
Copy link
Member

.shellcheckrc, .codespell_ignore and .cmake-format.json is currently unused due to #71 .

.cmake-format.json is not used by gersemi, the current cmake linter, thus removed.
.shellcheckrc is not used as shellcheck was removed in #71 . This is removed as there isn't significant shell scripts in this repo.
codespell is added back, this suggestion is up to the current maintainers to remove/ add back. I will add codespell to upstream (exemplar) as well, I don't know why I didn't add this in the first place.

Dependencies of pre-commit hooks are updated as well.

@coveralls
Copy link

Coverage Status

coverage: 91.209%. remained the same
when pulling 19a5e5f on wusatosi:cleanup
into 5765b9d on bemanproject:main.

Copy link
Member

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wusatosi wusatosi merged commit db756d0 into bemanproject:main Dec 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants