Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing assignment operator from 'nullopt_t' #95

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Add missing assignment operator from 'nullopt_t' #95

merged 3 commits into from
Jan 4, 2025

Conversation

jiixyj
Copy link
Contributor

@jiixyj jiixyj commented Dec 31, 2024

This adds the missing operator and a test.

@jiixyj jiixyj mentioned this pull request Dec 31, 2024
Closed
@coveralls
Copy link

coveralls commented Dec 31, 2024 •
edited
Loading

Coverage Status

coverage: 93.091% (+0.08%) from 93.015%
when pulling e280641 on jiixyj:missing-nullopt-assignment
into 08c8477 on bemanproject:main.

steve-downey
steve-downey approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@neatudarius neatudarius merged commit 5460182 into bemanproject:main Jan 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neatudarius neatudarius neatudarius approved these changes

@steve-downey steve-downey steve-downey approved these changes

@camio camio Awaiting requested review from camio camio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiixyj @coveralls @steve-downey @neatudarius