Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: combine usages of docker-compose.yml files into a single file #566

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

brianheineman
Copy link
Contributor

While trying to determine how to build the project for the first time I noticed a docker-compose.yml file in the base directory. I assumed this was used to build the project, but it appears(?) that the docker compose files in the docker/ directory are used for that purpose and the one in root is used for pulling/pushing the public images(?). I spent a little time looking at the various docker-compose*.yml files and noticed that they could likely be combined into a single file which might it easier for folks new to the project (but familiar with docker) to reason on. I could be misunderstanding the usage of the files, but I thought a PR might be the easiest / clearest way to communicate my understanding (and have it corrected if mistaken).

I removed the version as I was getting this warning:
image

I moved docker/run.sh to / and updated it to expect the docker-compose.yml file as a sibling in the same directory; I use RustRover and they have a run option in the gutter of shell scripts; this change makes the script work in this context regardless of the pwd.

I added a default value for ARCH to the build args that works for Mac with ARM processors; which I recall reading you are using(?); if you use x64, you probably want to change the defaults (fwiw, I use a Mac M3). This change allows someone to use docker compose directly without having to go through run.sh.

@brianheineman brianheineman force-pushed the docker-compose-config branch 2 times, most recently from 887df2d to 3295591 Compare February 6, 2025 23:05
@epompeii epompeii merged commit 0ba773e into bencherdev:main Feb 7, 2025
@epompeii
Copy link
Member

epompeii commented Feb 7, 2025

Great, thank you @brianheineman!

@brianheineman brianheineman deleted the docker-compose-config branch February 7, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants