chore: combine usages of docker-compose.yml files into a single file #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to determine how to build the project for the first time I noticed a
docker-compose.yml
file in the base directory. I assumed this was used to build the project, but it appears(?) that the docker compose files in thedocker/
directory are used for that purpose and the one in root is used for pulling/pushing the public images(?). I spent a little time looking at the variousdocker-compose*.yml
files and noticed that they could likely be combined into a single file which might it easier for folks new to the project (but familiar with docker) to reason on. I could be misunderstanding the usage of the files, but I thought a PR might be the easiest / clearest way to communicate my understanding (and have it corrected if mistaken).I removed the version as I was getting this warning:
![image](https://private-user-images.githubusercontent.com/3210678/410673537-0ea77c5e-7581-489b-b44d-c475bf5afe1d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMTUwOTEsIm5iZiI6MTczOTIxNDc5MSwicGF0aCI6Ii8zMjEwNjc4LzQxMDY3MzUzNy0wZWE3N2M1ZS03NTgxLTQ4OWItYjQ0ZC1jNDc1YmY1YWZlMWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMTkxMzExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTI0ZjVmMmNiNGY2MWM4NGRjYTU1ZmQxZTU1ZjVlZWY2ZWQ3ODdkMzFkZjBiYTBmMzRlODdkNGY2ZmQ1YzEzYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.6qpEhsscz-NB2TfiNOfQYI8zTdtAOmogzJnnJaFzaTE)
I moved
docker/run.sh
to/
and updated it to expect thedocker-compose.yml
file as a sibling in the same directory; I use RustRover and they have a run option in the gutter of shell scripts; this change makes the script work in this context regardless of the pwd.I added a default value for
ARCH
to the build args that works for Mac with ARM processors; which I recall reading you are using(?); if you use x64, you probably want to change the defaults (fwiw, I use a Mac M3). This change allows someone to usedocker compose
directly without having to go throughrun.sh
.