Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ansi support #56

Merged
merged 6 commits into from
Jan 21, 2024
Merged

Improve ansi support #56

merged 6 commits into from
Jan 21, 2024

Conversation

benpollarduk
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (2b0c3a5) 70.74% compared to head (04c99cf) 72.55%.

Files Patch % Lines
...ventureFramework/Rendering/Frames/GridTextFrame.cs 23.52% 11 Missing and 2 partials ⚠️
...ering/FrameBuilders/Color/ColorRegionMapBuilder.cs 78.57% 2 Missing and 1 partial ⚠️
...ring/FrameBuilders/Color/ColorSceneFrameBuilder.cs 72.72% 1 Missing and 2 partials ⚠️
...reFramework/Assets/Characters/PlayableCharacter.cs 0.00% 0 Missing and 1 partial ⚠️
...amework/Interpretation/CustomCommandInterpreter.cs 0.00% 1 Missing ⚠️
...Framework/Interpretation/GameCommandInterpreter.cs 0.00% 1 Missing ⚠️
...ework/Rendering/FrameBuilders/GridStringBuilder.cs 75.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   70.74%   72.55%   +1.81%     
==========================================
  Files         103       87      -16     
  Lines        3873     3112     -761     
  Branches      575      463     -112     
==========================================
- Hits         2740     2258     -482     
+ Misses        920      699     -221     
+ Partials      213      155      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
No data about Coverage
2.6% Duplication on New Code

See analysis details on SonarCloud

@benpollarduk benpollarduk merged commit f6cb6a2 into main Jan 21, 2024
2 checks passed
@benpollarduk benpollarduk deleted the improve-ansi-support branch January 21, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants