Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend stale txns on startup #86

Merged
merged 9 commits into from
May 22, 2024
Merged

Resend stale txns on startup #86

merged 9 commits into from
May 22, 2024

Conversation

hunter-bera
Copy link
Contributor

No description provided.

@hunter-bera hunter-bera requested review from itsdevbear and calbera May 16, 2024 15:48
@calbera calbera linked an issue May 16, 2024 that may be closed by this pull request
client/eth/client.go Outdated Show resolved Hide resolved
@hunter-bera hunter-bera requested a review from calbera May 16, 2024 19:54
calbera
calbera previously approved these changes May 17, 2024
Copy link
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Can you also add a TODO on the noncer, for the pendingNonces map smth like: "TODO: purge old nonces from the map to avoid infinite memory growth"

Copy link
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hunter-bera hunter-bera added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 000ac92 May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactor restart edge case
2 participants