fixes hash result not being distributed evenly over the bitarray

berkay-dincer · Nov 14, 2019 · b33ccb4 · b33ccb4
1 parent c1278a6
commit b33ccb4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 15 deletions.
diff --git a/bloomfpy/bloompy.py b/bloomfpy/bloompy.py
@@ -38,15 +38,15 @@ def __len__(self):
         return self.count
 
     def _hash_value(self, key, salt):
-        hashfunc = hashlib.sha1()
+        hashfunc = hashlib.sha256()
         if isinstance(key, str):
             key = key.encode('utf-8')
         else:
             key = str(key).encode('utf-8')
 
         hashfunc.update(key + salt.bytes)
-        for idx in hashfunc.digest():
-            return idx % self.num_bits
+        uint = int.from_bytes(hashfunc.digest(), "little")
+        return uint % self.num_bits
 
     def add(self, key):
         if self.count > self.capacity:

diff --git a/bloomfpy/main.py b/bloomfpy/main.py