This repository has been archived by the owner on Dec 26, 2017. It is now read-only.
Remove ChefDK dependency in favor of berkshelf gem #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: not everyone who are trying to run Vagrant with Chef provisioning prefer to have the bulky installation of ChefDK, and berksfile gem simply works. Judging by the amount of issues complaining about being unable to locate berksfile gem, this is often a problem: berkshelf#318 berkshelf#315
thommay
suggested changes
Nov 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: not everyone who are trying to run Vagrant with Chef provisioning prefer to have the bulky installation of ChefDK, and berksfile gem simply works.
Judging by the amount of issues complaining about being unable to locate berksfile gem, this is often a problem:
#318
#315
I have doubts about this PR getting merged, as it's an opinionated change, and repo itself is somewhat abandoned, so I am going to maintain a fork with new vagrant plugin, i.e.
vagrant-berkshelf-nochefdkif this won't get accepted soon.