-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obs/fix-actus #2344
Obs/fix-actus #2344
Conversation
WalkthroughThe updates reflect a focus on data presentation and accessibility improvements. A graph component is reintroduced in the observatory's territory page, while resource pages receive a data sorting tweak, shifting from creation to publication dates. Accessibility is enhanced in map components through keyboard focus capability. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (7)
- public/src/app/observatoire/territoire/page.tsx (2 hunks)
- public/src/app/ressources/page.tsx (2 hunks)
- public/src/app/ressources/page/[id]/page.tsx (2 hunks)
- public/src/components/observatoire/maps/DeckMap.tsx (1 hunks)
- public/src/components/observatoire/maps/Map.tsx (1 hunks)
- public/src/interfaces/cms/collectionsInterface.ts (1 hunks)
- public/src/styles/global.scss (1 hunks)
Files skipped from review due to trivial changes (1)
- public/src/styles/global.scss
Additional comments: 9
public/src/interfaces/cms/collectionsInterface.ts (1)
- 22-22: The addition of the
date_publi
property to theRessource
interface is consistent with the other date-related properties and aligns with the PR objectives.public/src/app/ressources/page.tsx (2)
- 23-23: The update of the sorting parameter from
date_created
todate_publi
aligns with the PR objectives to sort resources by publication date.- 41-41: The update in the date retrieval to use
date_publi
is consistent with the change in the sorting parameter and the PR objectives.public/src/app/ressources/page/[id]/page.tsx (2)
- 44-44: The modification of the sorting parameter from 'date_created' to 'date_publi' is consistent with the PR objectives and similar changes in other parts of the application.
- 63-63: The update in the date retrieval to use
date_publi
is consistent with the change in the sorting parameter and the PR objectives.public/src/components/observatoire/maps/DeckMap.tsx (1)
- 54-54: The addition of
tabIndex={0}
to thediv
element is a positive change for accessibility, allowing keyboard users to focus on the map component.public/src/components/observatoire/maps/Map.tsx (1)
- 46-46: The addition of
tabIndex={0}
to thediv
element enhances accessibility by allowing keyboard navigation, aligning with the PR's objectives for accessibility improvements.public/src/app/observatoire/territoire/page.tsx (2)
- 15-15: The import statement for
RepartitionHoraireGraph
has been added, which is necessary for the reintroduction of the component in the JSX structure.- 56-58: The restoration of the
RepartitionHoraireGraph
component in the JSX structure is consistent with the PR objectives to restore functionality to this component.
Summary by CodeRabbit
New Features
RepartitionHoraireGraph
component for enhanced data visualization.Enhancements
Accessibility Improvements
tabIndex
attributes to map components for better keyboard navigation.Style Updates