Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obs/fix-actus #2344

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Obs/fix-actus #2344

merged 5 commits into from
Jan 15, 2024

Conversation

Datayama38
Copy link
Collaborator

@Datayama38 Datayama38 commented Dec 14, 2023

Summary by CodeRabbit

  • New Features

    • Restored the RepartitionHoraireGraph component for enhanced data visualization.
    • Improved keyboard accessibility with focusable map components.
  • Enhancements

    • Updated resource sorting and display to use publication date instead of creation date.
  • Accessibility Improvements

    • Added tabIndex attributes to map components for better keyboard navigation.
  • Style Updates

    • Adjusted z-index for specific elements to refine layout stacking.
    • Ensured consistent aspect ratio for images with an important declaration.

Copy link
Contributor

coderabbitai bot commented Jan 15, 2024

Walkthrough

The updates reflect a focus on data presentation and accessibility improvements. A graph component is reintroduced in the observatory's territory page, while resource pages receive a data sorting tweak, shifting from creation to publication dates. Accessibility is enhanced in map components through keyboard focus capability. The Ressource interface now includes a date_publi property, and a CSS update enhances z-index management and image aspect ratio consistency.

Changes

File Path Change Summary
.../observatoire/territoire/page.tsx Reintegrated RepartitionHoraireGraph component and added its import statement.
.../ressources/page.tsx
.../ressources/page/[id]/page.tsx
Updated sorting parameter from date_created to date_publi and adjusted date retrieval.
.../observatoire/maps/DeckMap.tsx
.../observatoire/maps/Map.tsx
Added tabIndex={0} to div for keyboard focus, improving accessibility.
.../interfaces/cms/collectionsInterface.ts Included new date_publi property of type Date in the Ressource interface.
.../styles/global.scss Introduced new z-index rule and added !important to aspect-ratio for image consistency.

Poem

🐇💻
In the land of code, where changes abound,
A rabbit hopped through, making things sound.
Dates shift in line, and graphs reappear,
With a tab and a jump, accessibility's here!
🌟🗺️

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 09e863b and 58a9a63.
Files selected for processing (7)
  • public/src/app/observatoire/territoire/page.tsx (2 hunks)
  • public/src/app/ressources/page.tsx (2 hunks)
  • public/src/app/ressources/page/[id]/page.tsx (2 hunks)
  • public/src/components/observatoire/maps/DeckMap.tsx (1 hunks)
  • public/src/components/observatoire/maps/Map.tsx (1 hunks)
  • public/src/interfaces/cms/collectionsInterface.ts (1 hunks)
  • public/src/styles/global.scss (1 hunks)
Files skipped from review due to trivial changes (1)
  • public/src/styles/global.scss
Additional comments: 9
public/src/interfaces/cms/collectionsInterface.ts (1)
  • 22-22: The addition of the date_publi property to the Ressource interface is consistent with the other date-related properties and aligns with the PR objectives.
public/src/app/ressources/page.tsx (2)
  • 23-23: The update of the sorting parameter from date_created to date_publi aligns with the PR objectives to sort resources by publication date.
  • 41-41: The update in the date retrieval to use date_publi is consistent with the change in the sorting parameter and the PR objectives.
public/src/app/ressources/page/[id]/page.tsx (2)
  • 44-44: The modification of the sorting parameter from 'date_created' to 'date_publi' is consistent with the PR objectives and similar changes in other parts of the application.
  • 63-63: The update in the date retrieval to use date_publi is consistent with the change in the sorting parameter and the PR objectives.
public/src/components/observatoire/maps/DeckMap.tsx (1)
  • 54-54: The addition of tabIndex={0} to the div element is a positive change for accessibility, allowing keyboard users to focus on the map component.
public/src/components/observatoire/maps/Map.tsx (1)
  • 46-46: The addition of tabIndex={0} to the div element enhances accessibility by allowing keyboard navigation, aligning with the PR's objectives for accessibility improvements.
public/src/app/observatoire/territoire/page.tsx (2)
  • 15-15: The import statement for RepartitionHoraireGraph has been added, which is necessary for the reintroduction of the component in the JSX structure.
  • 56-58: The restoration of the RepartitionHoraireGraph component in the JSX structure is consistent with the PR objectives to restore functionality to this component.

@jonathanfallon jonathanfallon merged commit e4d89f1 into main Jan 15, 2024
10 checks passed
@jonathanfallon jonathanfallon deleted the obs/fix-actus branch January 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants