-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: cms deploy + meilisearch #2388
Conversation
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (8)
WalkthroughThe recent updates involve modifications to the deployment workflow, CMS configuration, and plugin settings. Specifically, the deployment script now uses a more current syntax for setting output variables, and environment variables dictate CMS versioning. In the CMS configurations, the default behavior for the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
cms/package-lock.json
is excluded by:!**/*.json
cms/package.json
is excluded by:!**/*.json
Files selected for processing (3)
- .github/workflows/deploy-cms.yml (2 hunks)
- cms/config/admin.ts (1 hunks)
- cms/config/plugins.ts (1 hunks)
Additional comments: 4
cms/config/admin.ts (1)
- 14-14: The change to set the
nps
flag default value tofalse
aligns with the PR objectives to adjust CMS configuration for a better user experience. Ensure that this change is communicated to stakeholders who might rely on NPS feedback being enabled by default.cms/config/plugins.ts (1)
- 30-35: The addition of
meilisearch
configuration withhost
andapiKey
is a significant enhancement for the CMS's search capabilities. It's crucial to ensure that theMEILISEARCH_MASTER_KEY
is securely managed and not exposed in any logs or error messages to prevent unauthorized access..github/workflows/deploy-cms.yml (2)
- 22-22: Updating the syntax for setting output values to use
$GITHUB_OUTPUT
aligns with GitHub Actions best practices. This change enhances maintainability and future-proofs the workflow.- 54-55: The script now correctly sets the
version
andimage
for the deployment, ensuring that the correct CMS version is deployed. However, ensure thatprocess.env.TARGET_VERSION
is correctly accessible in this context. Typically, environment variables in GitHub Actions are accessed through${{ env.VAR_NAME }}
. Verify thatprocess.env.TARGET_VERSION
is the intended usage and works as expected in this workflow.
Summary by CodeRabbit
meilisearch
support with configuration options for host and apiKey.nps
flag in admin configuration to improve user experience.