remove console.log

[jonathanfallon]

#fixes (issues)

Description

Checklist

• j'ai suivi les guidelines du "clean code"
• j'ai mis à jour la documentation technique dans /api/specs
• ajout ou mise à jour des tests unitaires
• ajout ou mise à jour des tests d'intégration

Merge

Je squash la PR et vérifie que le message de commit utilise la convention d'Angular :

Voir la convention de message de commit...

<type>(<scope>): <short summary>
  │       │             │
  │       │             └─⫸ Summary in present tense. Not capitalized. No period at the end.
  │       │
  │       └─⫸ Commit Scope: proxy|acquisition|export|...
  │
  └─⫸ Commit Type: build|ci|docs|feat|fix|perf|refactor|test

Types de commit

• build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
• ci: Changes to our CI configuration files and scripts (examples: Github Actions)
• docs: Documentation only changes
• feat: A new feature (Minor bump)
• fix: A bug fix (Patch bump)
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• test: Adding missing tests or correcting existing tests

Le scope (optionnel) précise le module ou le composant impacté par le commit.

Summary by CodeRabbit

• Chores
  • Updated permissions for data migration commands to support secure operations.
  • Streamlined configuration merging to simplify how system settings are applied.
  • Removed unnecessary debug logging during file uploads and data queries for cleaner system logs.

[coderabbitai]

Walkthrough

The changes involve updates across multiple files. In the api/justfile, the permissions for the external_data_migrate command are modified by replacing --allow-import with --allow-run. In buildMigrator.ts, the configuration merging strategy changes from using a deep merge function to a shallow merge via the spread operator. Additionally, debugging console log statements are removed from both the storage provider and the territories repository files.

Changes

File(s)	Change Summary
api/justfile	Updated the external_data_migrate command: removed --allow-import and added --allow-run.
api/src/db/geo/buildMigrator.ts	Replaced deep merge (collections.deepMerge) with a shallow merge using the spread operator for configuration merging.
api/src/pdc/...S3StorageProvider.ts api/src/pdc/...TerritoriesRepositoryProvider.ts	Removed debugging console log statements from the S3 upload method and the SQL query execution in getTerritories.

Suggested reviewers

• nmrgt

Poem

I'm a rabbit, hopping through lines of code,
Carrots of change in every mode.
Permissions swapped and merges redone,
Logs removed, our work's well spun.
With each small tweak, new paths appear—
A joyful update for all to cheer! 🐇🎉

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b50d653 and df0a4ef.

📒 Files selected for processing (4)

• api/justfile (1 hunks)
• api/src/db/geo/buildMigrator.ts (1 hunks)
• api/src/pdc/providers/storage/S3StorageProvider.ts (0 hunks)
• api/src/pdc/services/dashboard/providers/TerritoriesRepositoryProvider.ts (0 hunks)

💤 Files with no reviewable changes (2)

• api/src/pdc/providers/storage/S3StorageProvider.ts
• api/src/pdc/services/dashboard/providers/TerritoriesRepositoryProvider.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Test

🔇 Additional comments (2)

api/src/db/geo/buildMigrator.ts (1)

14-14: Verify the impact of switching to shallow merge.

The change from deep merge to shallow merge via spread operator could lead to missing configurations if either defaultConfig.app or userConfig.app contain nested objects, as only top-level properties will be merged.

Run the following script to check for nested properties in the config objects:

Consider using a deep merge utility like lodash.merge or implementing a custom deep merge function if nested properties are found:

import { merge } from 'lodash';
const appConfig = merge({}, defaultConfig.app, userConfig.app) as AppConfigInterface;

api/justfile (1)

126-126: LGTM! Permission change aligns with security best practices.

The change from --allow-import to --allow-run improves security by:

1. Removing unnecessary import permissions
2. Granting only the required permissions for subprocess execution

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.