add modification rule support for betamax #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…custom logic just like a MatchRule before returning the response.
# Resolved Conflicts: # betamax-core/src/main/java/software/betamax/Configuration.java # betamax-core/src/main/java/software/betamax/ModifyRule.java # betamax-core/src/main/java/software/betamax/tape/MemoryTape.java # betamax-core/src/main/java/software/betamax/tape/Tape.java
|
Hey guys, can you take a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview:
This will allow users to modify responses and send them back to the client. This was a feature that we required since our requests were dynamic and sent unique ids in them. It was required to send the unique id back in the response which I have written a custom modify rule for.
Modify rules will be configured just the way matching rules are. This will allow users to write their own custom logic. The only modify rule that comes with it by default is a no-op.