Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observers missing API for triggers targetting components on a given Entity #14074

Open
james-j-obrien opened this issue Jun 30, 2024 · 0 comments · May be fixed by #16326
Open

Observers missing API for triggers targetting components on a given Entity #14074

james-j-obrien opened this issue Jun 30, 2024 · 0 comments · May be fixed by #16326
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@james-j-obrien
Copy link
Contributor

james-j-obrien commented Jun 30, 2024 •
edited
Loading

What problem does this solve or what need does it fill?

  • Only unsafe APIs currently exist that allow you to specify both target components and entities, used internally for OnAdd, OnInsert, etc. This behaviour should be accessible to users via the safe APIs

What solution would you like?

  • Implement TriggerTargets for a combination of Entity and ComponentId.

Additional context

This API seems to have been dropped in the refactor from builder to TriggerTargets, we should probably try and check in a fix before release although it is possible to just manually implement TriggerTargets.
@james-j-obrien james-j-obrien added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled A-ECS Entities, components, systems, and events D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jun 30, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed S-Needs-Triage This issue needs to be labelled labels Jul 2, 2024
@cBournhonesque cBournhonesque mentioned this issue Jul 31, 2024
Closed
@BenjaminBrienen BenjaminBrienen linked a pull request Nov 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
2 participants
@alice-i-cecile @james-j-obrien