-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Model Support & Fix Iterator Errors #46
Conversation
Add as ExceptionModel to be clear what we're refering to
Handle case where config option isn't supplied for backwards compatability
PR Summary
|
Hey @bezhanSalleh I updated workflow to test bench 8.0, I think it shouldn't cause problems but test workflow again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't the issue. the issue was phpunit. could you merge it with the main though, it's fixed now.
We missing anything |
nah, all seems. good. will do a release tonight. thanks. |
Thanks |
Custom Models
Custom models are required in some scenarios such as having a multi tenant database where we want to enforce that the model uses the central database.
Changes made:
Closes #44
Fix Iterator Errors
In order to temporarily supress warnings & errors the \ReturnTypeWillChange attribute has been added to functions inside parser.php
Closes #45