Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resource cluster && navigation group from config file #64

Closed
wants to merge 1 commit into from

Conversation

abdosaeedelhassan
Copy link

The reasons of this are
1- sometime need to attach exception resource to specific cluster ex: app monitoring cluster
2- sometime need the exception resource without navigation group, putting it inside config file more effusion from translation file

Copy link

what-the-diff bot commented Oct 31, 2024

PR Summary

  • New Configuration Options Introduced:

    • The PR added new configurations under 'cluster' and 'navigation_group' in a specific settings file. This offers flexibility and customization for users.
  • Enhancement in Exception Resource:

    • A method 'getCluster' has been added which fetches the cluster configuration value. This eases retrieval of settings.
  • Navigation Group Retrieval Updated:

    • The retrieval process for 'navigation_group' from the settings has been revised. 'Management' is now the default value if no specific configuration is found. This modification increases system resilience by handling inexistent configurations.
  • Code Formatting Enhanced:

    • The PR incorporates style improvements such as removing unnecessary spaces in function definitions, contributing to better readability.
  • Navigation Registration Check Simplified:

    • The check within the 'shouldRegisterNavigation' function has been streamlined. Now it directly returns a boolean value based on a specific configuration. This simplification reduces code complexity.
  • Active Tab Fetching Perfected in form() function:

    • The configuration is now effectively used to determine the 'activeTab', ensuring correct tab information is always displayed.
  • Consistency in Table Column Labels:

    • Formatting for label definitions in table columns has been revised to align with updated localization calls. This fosters a more consistent user interface.
  • No Alterations in Tabs Structure:

    • Though the appearances of the tabs and their organization have been improved for consistency, their fundamental structure and behavior remain intact. This ensures user familiarity and workflow do not get disturbed.

@bezhanSalleh
Copy link
Owner

bezhanSalleh commented Nov 6, 2024

these kinda customizations are already resolved #49
check it out and let me know if something is missing. cause i have already removed the global config and now you can configure it based on the panel you install the plugin for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants