-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HasShieldFormComponents.php #476
base: 3.x
Are you sure you want to change the base?
Conversation
to fix the resourceCheckboxColums not being taken into account.
PR Summary
|
Sorry I just tested it and if fails. Should have tested it before submitting my bad ! |
Well, just made a typo in the new method name: |
Update HasShieldFormComponents.php
i'm not sure what you mean by "When we try to set the checkbox settings on the resource, it only takes into account the general checkbox colums setting and not the particular one for the resources." could you add visually depict the issue you are trying to fix? |
When we try to set the checkbox settings on the resource, it only takes into account the general checkbox colums setting and not the particular one for the resources.
This PR should fix this
Duplicated the method getCheckboxListFormComponent() into a new one getCheckboxListFormComponentForResource() and added the getResourceCheckboxListColumns()