BUGFIX: Missing Widget Titles -- Add additional null check for getHeading() within getLocalizedWidgetLabel() #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LocalizedWidgetLabel() This check is necessary because Filament\Widgets\StatsOverviewWidget.php always has a base getHeading() method. This causes the "default" branch within the match statement to not execute. This currently works as-is for the table widgets because it uses a different method name --> getTableHeading() and does not have a getHeading() method. Adding this null check should give us the expected behavior.
PR Summary
|
|
It seems this was addressed as part of #473. I was not able to tell from the PR title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This null check is necessary because Filament\Widgets\StatsOverviewWidget.php always has a base getHeading() method.
This causes the "default" branch within the match statement to not execute, resulting in missing Widget titles.
See #493
This currently works as-is for the table widgets because it uses a different method name --> getTableHeading() and does not have a getHeading() method.
Adding this null check should give us the expected behavior.