fix evil twin bug #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if there was no path to a trust anchor, verify_cert() set *chainOK to false but returned success. Now, verify_cert() simply returns ERR_SCM_NOTVALID and there is no chainOK parameter. An evil twin can make it appear as if there is a path to a trust anchor, so there's no substantial difference between a certificate without a path to a trust anchor and an invalid certificate with a path to a trust anchor.
isRoot==1 implies that the cert is a trust anchor, which is not how this variable is used. Rename isRoot to already_verified to match its actual semantics a bit better.
This makes it easier to follow the code.
for clarity
and defer its declaration to discourage misuse
The OpenSSL docs say that X509_verify_cert() might return a negative error code and recomments applications check for <= 0 when testing for success.
This will make it easier to edit verify_cert() to fix the evil twin bug.
to match verify_cert()
This will make it easier to edit verify_cert() to fix the evil twin bug.
Given a starting SKI and subject, this function finds all certification paths up to a trust anchor. For each path it finds it calls a callback to perform validation (or some other task).
find_cert_paths() walks all certification paths, so this change fixes the evil twin bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #29