-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refact and move selection in Edit Mode #3
Open
Igorxp5
wants to merge
11
commits into
bhushan6:main
Choose a base branch
from
Igorxp5:feat/move
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click when bricks are selected it moves them. By removing unselect, the user has the feedback when they're trying to add a brick in invalid position. Select only by shift key.
@Igorxp5 is attempting to deploy a commit to the Bhushan Nana Wagh's projects Team on Vercel. A member of the Team first needs to authorize it. |
Scene and its children were being rendered every mouse move, causing render lag in some slower hardwares
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I was looking for the move selection feature in the project, and saw it wasn't present. To make that possible and easy to build, I've refactored the brick positioning and other stuff. See the list of changes below:
To be able to migrate current Room storage scheme to the new one, I build this script to update every room in the Liveblocks project: liveblocks-migration.js. Before running it, set Liveblocks SECRECT KEY in the script file (API_KEY constant). Note, the API SECRECT KEY is different from API PUBLIC KEY.