Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[34] calculate ip extension lenght based on version #68

Conversation

biandratti
Copy link
Owner

Pull Request Template

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change:

Please select the appropriate tags in the PR if necessary.

Motivation

Keeping thing up-to-date

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce, and the Operative System used.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • Select the appropriate tags in the PR if necessary.

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.45%. Comparing base (b074733) to head (bc0da52).

Files with missing lines Patch % Lines
src/ip_options.rs 72.22% 5 Missing ⚠️
src/tcp_process.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   50.27%   50.45%   +0.18%     
==========================================
  Files          15       16       +1     
  Lines        1289     1308      +19     
==========================================
+ Hits          648      660      +12     
- Misses        641      648       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biandratti biandratti marked this pull request as ready for review February 23, 2025 14:04
@biandratti biandratti merged commit fc55222 into master Feb 23, 2025
4 checks passed
@biandratti biandratti deleted the 36-evaluate-olen-implementation-for-ipv4-options-and-ipv6-extension-headers-under-the-pnet-library branch February 23, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate olen implementation for IPv4 Options and IPv6 Extension Headers under the pnet Library
2 participants