Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated recently used colors into the color picker #2412

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Integrated recently used colors into the color picker #2412

merged 8 commits into from
Jan 28, 2025

Conversation

josephmathew900
Copy link
Contributor

@josephmathew900 josephmathew900 commented Jan 22, 2025 •
edited
Loading

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2412 January 22, 2025 13:29 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2412 January 22, 2025 14:53 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2412 January 22, 2025 14:54 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2412 January 23, 2025 08:38 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2412 January 23, 2025 12:10 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2412 January 23, 2025 12:20 Inactive
@josephmathew900 josephmathew900 added the patch Releases small requests or bug fixes. label Jan 24, 2025
@praveen-murali-ind
Copy link
Contributor

@praveen-murali-ind _a Assigning myself to review the UI.

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2412 January 24, 2025 07:19 Inactive
@praveen-murali-ind
Copy link
Contributor

praveen-murali-ind commented Jan 24, 2025 •
edited
Loading

@josephmathew900 _a I've updated the default color palette. As discussed in our call, please address the issues related to the local storage color update.

Todo

  • Recently used colors differ in each color picker.
  • The new color picker doesn't display recently used colors on the first click.
Screenshot 2025-01-24 at 12 43 29 PM Screenshot 2025-01-24 at 12 43 19 PM Screenshot 2025-01-24 at 12 43 12 PM Screenshot 2025-01-24 at 12 43 05 PM

@josephmathew900
Copy link
Contributor Author

@praveen-murali-ind _a Please check now.

praveen-murali-ind
praveen-murali-ind approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@praveen-murali-ind praveen-murali-ind merged commit f2cb484 into main Jan 28, 2025
1 check passed
@praveen-murali-ind praveen-murali-ind deleted the 2411-show-recently-used-colors-in-color-picker branch January 28, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveen-murali-ind praveen-murali-ind praveen-murali-ind approved these changes

Assignees

@praveen-murali-ind praveen-murali-ind

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing recently used colors in color picker
2 participants
@josephmathew900 @praveen-murali-ind