Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resizeable image on cart image #1195

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Use resizeable image on cart image #1195

merged 1 commit into from
Jul 31, 2024

Conversation

bookernath
Copy link
Contributor

@bookernath bookernath commented Jul 31, 2024

What/Why?

Update cart image to use the new resizeable image node instead of the deprecated imageUrl static image.

Testing

Preview deployment

image

@bookernath bookernath requested a review from a team as a code owner July 31, 2024 14:44
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 4:15pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jul 31, 2024 4:15pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 4:15pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 4:15pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 4:15pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 4:15pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 4:15pm

Copy link

changeset-bot bot commented Jul 31, 2024

⚠️ No Changeset found

Latest commit: 714d60c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-hzl5qxxrh-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 79
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@bookernath bookernath added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit c00b6fb Jul 31, 2024
12 of 13 checks passed
@bookernath bookernath deleted the cart-image branch July 31, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants