fix(core): issue with keys in form components #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
jorgemoya
force-pushed
the
fix-issue-with-keys
branch
from
b589180 to
b81c10b
Compare
🦋 Changeset detectedLatest commit: 5884871 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jorgemoya
force-pushed
the
fix-issue-with-keys
branch
from
b81c10b to
0de817c
Compare
jorgemoya
changed the title
chanceaclark
approved these changes
Aug 1, 2024
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-j3e8s4q46-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
This was referenced Aug 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Fixes issue with duplicate keys by setting key before spreading props. This seems to be a NextJS issue, where key is removed if used after spreading props.
Testing
Locally no longer see duplicate keys messages.