Icon Component & Merging skeleton / empty states #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
agurtovoy
reviewed
Nov 11, 2024
| import '~/makeswift/components/featured-products-carousel/featured-products-carousel.makeswift'; | ||
| import '~/makeswift/components/featured-products-list/featured-products-list.makeswift'; | ||
| // import '~/makeswift/components/featured-products-carousel/featured-products-carousel.makeswift'; | ||
| // import '~/makeswift/components/featured-products-list/featured-products-list.makeswift'; |
There was a problem hiding this comment.
@apledger should we uncomment these?
agurtovoy
previously approved these changes
Nov 11, 2024
apledger
force-pushed
the
alan/vib-880-create-icon-component-for-makeswift
branch
from
6ae2c2a
to
879e4e6
Compare
apledger
force-pushed
the
alan/vib-880-create-icon-component-for-makeswift
branch
from
e2978a7
to
dac0044
Compare
apledger
force-pushed
the
alan/vib-880-create-icon-component-for-makeswift
branch
from
dac0044
to
9902676
Compare
apledger
force-pushed
the
alan/vib-880-create-icon-component-for-makeswift
branch
from
9902676
to
87c3267
Compare
agurtovoy
approved these changes
Nov 11, 2024
andrewreifman
deleted the
alan/vib-880-create-icon-component-for-makeswift
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iconcomponent to use thedynamicIconImportsfromlucide-reactto avoid bundling all icons.ProductListfor usage in the Makeswift client component version.ProductsCarouselandCardCarouselskeletons with their empty states for better transitions between the two.